Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Launch private registry with init #10822

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

dereknola
Copy link
Contributor

Proposed Changes

  • Launch the private registry container with --init so if it becomes a zombie, the container can be killed on cleanup.

Types of Changes

Verification

Testing

Linked Issues

#10821

User-Facing Change


Further Comments

…leanup

Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.90%. Comparing base (254c16f) to head (1924584).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10822      +/-   ##
==========================================
- Coverage   50.03%   43.90%   -6.14%     
==========================================
  Files         178      178              
  Lines       14753    14753              
==========================================
- Hits         7382     6477     -905     
- Misses       6032     7089    +1057     
+ Partials     1339     1187     -152     
Flag Coverage Δ
e2etests 36.22% <ø> (-10.02%) ⬇️
inttests 36.80% <ø> (+0.01%) ⬆️
unittests 13.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola marked this pull request as ready for review September 4, 2024 20:59
@dereknola dereknola requested a review from a team as a code owner September 4, 2024 20:59
@dereknola dereknola merged commit 36282dc into k3s-io:master Sep 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants