Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI 1.1.0 support #1273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented May 2, 2024

This PR support CNI SPEC 1.1.0, with new CNI commands, GC and STATUS.

@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 63.303% (-0.8%) from 64.103%
when pulling 8508191 on s1061123:cni110
into e074c2a on k8snetworkplumbingwg:master.

@s1061123 s1061123 changed the title CNI 1.1.0 support [WIP]CNI 1.1.0 support May 20, 2024
@s1061123
Copy link
Member Author

Need to discuss: May need to disable GC for now because it may happens unexpected resource removal by GC (if same CNI plugin is used for both, cluster network and net-attach-def, it mihgt be happen)

@s1061123 s1061123 mentioned this pull request May 24, 2024
@s1061123 s1061123 changed the title [WIP]CNI 1.1.0 support CNI 1.1.0 support May 24, 2024
@s1061123
Copy link
Member Author

Need to discuss: May need to disable GC for now because it may happens unexpected resource removal by GC (if same CNI plugin is used for both, cluster network and net-attach-def, it mihgt be happen)

Changed.

pkg/multus/multus.go Dismissed Show dismissed Hide dismissed
pkg/multus/multus.go Dismissed Show dismissed Hide dismissed
@maiqueb
Copy link
Collaborator

maiqueb commented May 30, 2024

/cc

Copy link

github-actions bot commented Sep 5, 2024

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 5, 2024
@github-actions github-actions bot closed this Sep 12, 2024
@s1061123 s1061123 reopened this Sep 12, 2024
@github-actions github-actions bot removed the Stale label Sep 13, 2024
This change supports up to date CNI 1.1 command, GC and STATUS for
cluster network.
This code changes CNI's GC command argument. Previously it just
passes from parent CNI runtime, however, it may causes unexpected
resource deletion if one CNI plugin is used in both cluster
network and net-attach-def. This change generates valid attachments
from multus CNI cache and passed to delegate CNI plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants