Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[software-bridges 4/x] Controller part #694

Merged
merged 4 commits into from
Jul 23, 2024
Merged

[software-bridges 4/x] Controller part #694

merged 4 commits into from
Jul 23, 2024

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Apr 30, 2024 •
edited
Loading

This PR contains controller's part of the software bridge management feature.

Context is Software bridge management feature

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10038935880

Details

  • 77 of 84 (91.67%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 43.351%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/sriov-network-config-daemon/start.go 1 2 50.0%
pkg/systemd/systemd.go 0 1 0.0%
controllers/sriovnetworknodepolicy_controller.go 0 5 0.0%
Totals Coverage Status
Change from base Build 10035896257: 0.3%
Covered Lines: 6341
Relevant Lines: 14627
💛 - Coveralls

@ykulazhenkov ykulazhenkov force-pushed the pr-autobridge-controller-part branch from 4b1cfdb to c6392ae Compare May 23, 2024 07:17
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@ykulazhenkov ykulazhenkov force-pushed the pr-autobridge-controller-part branch from c6392ae to 23d0dd0 Compare June 26, 2024 07:51
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov force-pushed the pr-autobridge-controller-part branch from 23d0dd0 to 8cc9e61 Compare July 9, 2024 13:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@ykulazhenkov
Copy link
Collaborator Author

@SchSeba I resolved merge conflicts in the PR, please take a look

SchSeba
SchSeba reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments and we can merge this one

api/v1/helper.go Show resolved Hide resolved
api/v1/helper_test.go
},
},
expectedBridges: v1.Bridges{},
expectedErr: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is externally manage not support at all or right now and will be in the future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the device is externally managed we are not managing bridges for it, but It is possible to create OVSNetwork for Externally managed PF to announce "manually" created resources. For externally managed PFs we are not changing PF-level settings. For me "software bridge config for PF" option is a PF-level settings and I think we should not change it externally managed for PFs.

pkg/webhook/validate.go Outdated
@@ -213,6 +213,15 @@ func staticValidateSriovNetworkNodePolicy(cr *sriovnetworkv1.SriovNetworkNodePol
if cr.Spec.DeviceType == consts.DeviceTypeVfioPci && cr.Spec.IsRdma {
return false, fmt.Errorf("'deviceType: vfio-pci' conflicts with 'isRdma: true'; Set 'deviceType' to (string)'netdevice' Or Set 'isRdma' to (bool)'false'")
}
if strings.EqualFold(cr.Spec.LinkType, consts.LinkTypeIB) && !cr.Spec.IsRdma {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was removed no?

78bde32

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Good catch! done

@ykulazhenkov
Add manageSoftwareBridges feature gate
618315d 
The feature gate controls state of the
manage software bridge feature.
This feature is disabled by default.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add logic to apply OVS bridge policy to state
f606e87 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add validation for bridge config to webhook
68afdfe 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov
Add logic to SriovNetworkNodePolicy controller to populate bridge config
f10b9a6 
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov ykulazhenkov force-pushed the pr-autobridge-controller-part branch from 8cc9e61 to f10b9a6 Compare July 22, 2024 10:15
@ykulazhenkov
Copy link
Collaborator Author

@SchSeba Thx for the review. I addressed your comments, please take another look.

SchSeba
SchSeba approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@adrianchiris adrianchiris merged commit 588abb4 into k8snetworkplumbingwg:master Jul 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykulazhenkov @coveralls @SchSeba @adrianchiris