Fix reconcile vf functional test

[SchSeba]

we should not lower the MTU on a primary SDN nic.

with this change we select a PF that is not the default route of the node or not the nic connected to the ovs bridge for openshift

[github-actions]

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[coveralls]

Pull Request Test Coverage Report for Build 10351277379

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 45.189%

---

Totals
Change from base Build 10318797846:	0.04%
Covered Lines:	6532
Relevant Lines:	14455

---

💛 - Coveralls

[zeeke]

Left few minor comments. As far as I understood, the main change in this PR is

unusedSriovDevices, err := findUnusedSriovDevices(node, sriovDeviceList)
							if err != nil {
								Skip(err.Error())
							}
							intf = unusedSriovDevices[0]

correct?

https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/744/files#diff-6665a7e475c21cad9c99b9463fba12769e300e6d1a6cc1323c9c3ca68e8cc120R1581

[zeeke]

can you use waitForNetAttachDef() here?

[zeeke]

please, extract a function like

Suggested change

	// update the interface
	intf = getInterfaceFromNodeStateByPciAddress(node, intf.PciAddr)
	func getInterfaceFromNodeStateByPciAddress(node, pciAddress string) {
	nodeState := &sriovv1.SriovNetworkNodeState{}
	err = clients.Get(context.Background(), runtimeclient.ObjectKey{Name: node, Namespace: operatorNamespace}, nodeState)
	Expect(err).ToNot(HaveOccurred())
	found := false
	for _, state := range nodeState.Status.Interfaces {
	if state.PciAddress == intf.PciAddress {
	intf = state.DeepCopy()
	found = true
	break
	}
	}
	Expect(found).To(BeTrue())
	}

WDYT?

[SchSeba]

Hi @zeeke when you have time please take another look :)

[zeeke]

LGTM!