Add "ol" and "ul" to nonPhrasing #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's not how testing works. Please add tests which fails in the current version but passes with your changes in this PR. |
|
Please exclude any changes to |
alexlamsl
reviewed
Mar 2, 2018
tests/index.html
Outdated
| @@ -3,12 +3,12 @@ | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <title>HTML Minifier Tests</title> | |||
| <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-2.5.0.css"> | |||
| <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-2.5.1.css"> | |||
There was a problem hiding this comment.
Please also exclude changes to this file.
alexlamsl
reviewed
Mar 2, 2018
|
|
||
| input = '<p>a<ol><li>item</li></ol></p>'; | ||
| output = '<p>a</p><ol><li>item</li></ol><p></p>'; | ||
| assert.equal(minify(input, { html5: true }), output); |
There was a problem hiding this comment.
Tests look good, thanks.
Can you add one more that also does removeOptionalTags: true to make sure the newly placed </p> doesn't get removed?
There was a problem hiding this comment.
The generated </p> before ul/ol should be removed because it's optional. I also added test to check the <p></p> at the end.
|
Sorry for added dist by mistake. |
This was referenced Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issue #888.
I didn't change any tests in this PR because there's no current test covering which tag belongs to non-phrasing tags.