Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seprate Viber tags with spaces #224

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Conversation

ankostis
Copy link
Contributor

...like hypothesis-source does.

Also use JSON1 SQLite extension to extract items from a JSON column.

Copy link
Owner

@karlicoss karlicoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment!
macos-latest, 3.6 pipeline failed, but looks like a random github glitch, will probably go away on next change

src/promnesia/sources/hypothesis.py Outdated Show resolved Hide resolved
@karlicoss
Copy link
Owner

looks ok, but think it conflicts with the previous PR merged before -- so needs a rebase/conflict resolution

@ankostis
Copy link
Contributor Author

ankostis commented Apr 1, 2021

Resolved conflict and did some suggested nit picks in #222.

@karlicoss karlicoss merged commit 137c3d2 into karlicoss:master Apr 1, 2021
@karlicoss
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants