-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring modules #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call. This is done in preparation for trying to split the modules future into new api and resource modules.
the fobo-pace module as a resouce reference. Implementing the new initiation schema and deprecating the "InitParam" usage.
karma4u101
added
buildsystem
enhansment
feature
and removed
buildsystem
enhansment
feature
labels
Jan 9, 2016
new initiation schema and deprecating the "InitParam" usage. Updating API documentation.
KinteicJS-Res modules.
breaking things for users on upgrade to v1.6.
reworking the code in tooklit module to to use it.
dependecy settings has been updated acodingly.
# Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is connected to #56 (Composing ToolKit) please read the issue report for more information on what this PR implements.
Improvements
This PR currently includes the following improvements:
Initialization
It's no longer necessary to use
FoBo.init()
in yourbootstrap.liftweb.Boot boot
method as each FoBo toolkit specified inboot
takes care of its own resouce/API set-up.Test coverage
Improved test coverage. Tests now covers all resource initialization using InitParam (deprecated), ToolKit and Resouce settings. API coverage has not been changed in this PR.
Modules
Below is a list of current (but not final) improvements for each FoBo module.
FoBo (meta module)
ToolKit.Init and Resouce.Init is implemented for:
AngularJS usage (Inc. API.Init)
FontAwesome
Pace
Kinetic
Google-Code-Prettify
JQuery
TwBs-Bootstrap3 (Inc. API.Init)
Twitter-Bootstrap (Inc. API.Init)
New tests has been added for the listed toolkit's using Resouce.Init and Toolkit.Init. Tests for InitParam.ToolKit has been updated/re-written.
AngularJS
Pace module
Kinetic module
Font-Awesome
Google-Code-Prettify
JQuery
TwBs-Bootstrap3
Twitter-Bootstrap
Deprecations
v1.3 deprecations or older is removed.
Removed
Bugfixes