Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PCRE pattern after LogParser::addPattern() #60

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

kassner
Copy link
Owner

@kassner kassner commented Jul 18, 2023

This allows addPattern and setFormat to be called in any order. No user should expect performance issues unless they're re-using/re-creating the LogParser instance at every row, which is somewhat counter intuitive.

@kassner kassner force-pushed the issue-59 branch 2 times, most recently from b5b4d74 to 2c995b0 Compare July 18, 2023 14:10
@kassner kassner marked this pull request as ready for review July 18, 2023 14:16
@kassner kassner merged commit ba411a2 into master Jul 18, 2023
8 checks passed
@kassner kassner deleted the issue-59 branch July 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant