Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing custom dataset adapters. #20349

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

Hilly12
Copy link
Contributor

@Hilly12 Hilly12 commented Oct 13, 2024

  • Allow passing a custom dataset adapter - this is to enable enqueuing ID tensors to TPUEmbedding before converting them to Jax arrays and putting them on tensorcores.
  • Small fix in compute_output_shape in embedding layer.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (5aa5f88) to head (f0eb570).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/trainers/data_adapters/__init__.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20349      +/-   ##
==========================================
+ Coverage   78.81%   78.87%   +0.06%     
==========================================
  Files         512      512              
  Lines       49063    49264     +201     
  Branches     9035     7953    -1082     
==========================================
+ Hits        38668    38859     +191     
- Misses       8530     8546      +16     
+ Partials     1865     1859       -6     
Flag Coverage Δ
keras 78.74% <50.00%> (+0.07%) ⬆️
keras-jax 62.40% <50.00%> (+0.13%) ⬆️
keras-numpy 57.42% <50.00%> (+0.01%) ⬆️
keras-tensorflow 63.64% <50.00%> (+0.08%) ⬆️
keras-torch 62.37% <50.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 14, 2024
@fchollet fchollet merged commit 713382b into keras-team:master Oct 14, 2024
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants