Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 support and sunsetting schedule #364

Closed
dcslagel opened this issue Jul 1, 2020 · 9 comments
Closed

Python 2.7 support and sunsetting schedule #364

dcslagel opened this issue Jul 1, 2020 · 9 comments
Labels

Comments

@dcslagel
Copy link
Collaborator

dcslagel commented Jul 1, 2020

Python.org stopped supporting Python 2.7 in January.
https://www.python.org/doc/sunset-python-2/

How long will Lasio continue Python 2.7 support?

@kinverarity1
Copy link
Owner

I'm happy to drop it once we need to. Looks like we'll need to for the work going into #327 but once that's merged, python 2.7 will no longer be supported.

In terms of releases, I'll so another minor release immediately before #327 is merged, so that will be the final release for 2.7.

@dcslagel
Copy link
Collaborator Author

dcslagel commented Jul 1, 2020

There are 75 projects (by GitHubs count) that depend on Lasio. It might be good to put an 2.7 sunsetting notice at the top of the README.md so other projects are aware and can make any needed adjustments.

@kinverarity1
Copy link
Owner

kinverarity1 commented Jul 1, 2020

Good idea. I guess there will be a couple things:

  • add sunsetting notice to readme (do now)
  • wait until Rearrange reader #327 is ready
  • tag a new minor release which will serve as the last python 2.7 release (v0.26)
  • create long term py27 branch
  • We can backport critical fixes into py27 and make bugfix releases against this version number if needed
  • merge changes to issue364-remove-py27-deps to remove python 2.7 support:
    • add a python_requires for 3+ to setup.py
    • update qualifiers in setup.py
    • remove Travis 2.7 tests
    • update readme and sphinx docs
  • merge issue364-remove-py27-deps to master
  • merge Rearrange reader #327 intomaster

Anything else I'm missing?

@dcslagel
Copy link
Collaborator Author

dcslagel commented Jul 1, 2020

Thats a good list. It looks thorough. :-)

question:
#327 (rearrange-reader) is looks like it is intended to merge to las3-develop branch. Will #327 also go directly to the master branch?

@kinverarity1
Copy link
Owner

I'm not sure why I targeted a separate branch. If it gets to a point where all tests are passing, I'll merge it into master.

@kinverarity1
Copy link
Owner

kinverarity1 commented Jul 8, 2020

@dcslagel Great work with #327! I've re-targeted the latter to master and once I get around to doing the relevant steps above, hopefully this weekend, I'll merge it.

@dcslagel
Copy link
Collaborator Author

dcslagel commented Jul 8, 2020

@kinverarity1, great, that's a good plan. thanks for the update.

The master branch has 71 commits and 17 additional tests since rearrange-reader initially forked. I'm going to make some rr_rebase_(x) branch(s) to attempt the rebase from master to rearrange-reader.

@dcslagel
Copy link
Collaborator Author

dcslagel commented Jul 8, 2020

I updated #327(rearrange-reader pull-request) with my rebase findings.

@kinverarity1
Copy link
Owner

#364 (removal of Python 2.7 support in theory and from CI testing) and #327 (removal of ability to run using Python 2.7) have been merged to master.

Thanks @dcslagel for raising this in the first place, and everyone for their patience 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants