-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CA certs to web clients #3193
Added CA certs to web clients #3193
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #3193 +/- ##
============================================
- Coverage 63.45% 63.37% -0.09%
+ Complexity 754 753 -1
============================================
Files 167 167
Lines 11791 11803 +12
Branches 238 238
============================================
- Hits 7482 7480 -2
- Misses 3749 3760 +11
- Partials 560 563 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...src/main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java
Outdated
Show resolved
Hide resolved
...src/main/java/dev/knative/eventing/kafka/broker/dispatcher/main/ConsumerVerticleBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support CA certs rotation and changes, we need to add them to the comparison here: https://github.com/knative-sandbox/eventing-kafka-broker/blob/4dd4f24c4f4f653d8d364d5ff4516195bdb330e5/data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/reconciler/impl/ResourcesReconcilerImpl.java#L234-L254
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
/cc @pierDipi |
/test unit-tests |
1 similar comment
/test unit-tests |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
e8ba86f
into
knative-extensions:main
Fixes #3129
Proposed Changes
To send an http request with TLS in vert.x, you need to call
postAbs()
(which we already do), and have theWebClient
configured to trust the CA certificate for the destination. So, the only necessary change is:WebClient
, pass in the appropriate CA certificate if it is not null/empty