Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CA certs to web clients #3193

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 5, 2023

Fixes #3129

Proposed Changes

To send an http request with TLS in vert.x, you need to call postAbs() (which we already do), and have the WebClient configured to trust the CA certificate for the destination. So, the only necessary change is:

  • When creating an instance of WebClient, pass in the appropriate CA certificate if it is not null/empty

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added area/data-plane size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3193 (af947d9) into main (4dd4f24) will decrease coverage by 0.09%.
The diff coverage is 25.00%.

❗ Current head af947d9 differs from pull request most recent head 6890ee1. Consider uploading reports for the commit 6890ee1 to get more accurate results

@@             Coverage Diff              @@
##               main    #3193      +/-   ##
============================================
- Coverage     63.45%   63.37%   -0.09%     
+ Complexity      754      753       -1     
============================================
  Files           167      167              
  Lines         11791    11803      +12     
  Branches        238      238              
============================================
- Hits           7482     7480       -2     
- Misses         3749     3760      +11     
- Partials        560      563       +3     
Flag Coverage Δ
java-unittests 79.57% <25.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roker/dispatcher/main/ConsumerVerticleBuilder.java 61.94% <25.00%> (-4.39%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 6, 2023

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi July 6, 2023 14:15
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 6, 2023

/test unit-tests

1 similar comment
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 6, 2023

/test unit-tests

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 6, 2023

/retest-required

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@Cali0707
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit e8ba86f into knative-extensions:main Jul 10, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Support sending events to TLS endpoints
2 participants