Updated comments explaining how the async prober works #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #3200 +/- ##
============================================
- Coverage 63.42% 63.40% -0.02%
Complexity 755 755
============================================
Files 167 167
Lines 11805 11805
Branches 241 241
============================================
- Hits 7487 7485 -2
- Misses 3754 3756 +2
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
Looks good! @Cali0707 |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/test channel-integration-tests-sasl-ssl |
knative-prow
bot
merged commit d672f98
into
knative-extensions:main
21 of 23 checks passed
Rahul-Kumar-prog
pushed a commit
to Rahul-Kumar-prog/eventing-kafka-broker
that referenced
this pull request
Jul 31, 2023
…sions#3200) Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation with @pierDipi the async prober code can be confusing when it asynchronously aggregates the status of the different IPs for each pod.
Proposed Changes