Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Vertx to 4.4.3 #3201

Merged
merged 13 commits into from
Jul 26, 2023
Merged

Bump Vertx to 4.4.3 #3201

merged 13 commits into from
Jul 26, 2023

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Jul 10, 2023 •
edited by pierDipi
Loading

As per title

@knative-prow
Copy link

knative-prow bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane labels Jul 10, 2023
@knative-prow knative-prow bot requested a review from aliok July 10, 2023 19:20
@knative-prow knative-prow bot requested a review from matzew July 10, 2023 19:20
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2023
@Leo6Leo Leo6Leo marked this pull request as ready for review July 10, 2023 19:45
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@knative-prow knative-prow bot requested a review from pierDipi July 10, 2023 19:45
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #3201 (de81e0d) into main (6794484) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 64.28%.

@@             Coverage Diff              @@
##               main    #3201      +/-   ##
============================================
- Coverage     63.61%   63.54%   -0.08%     
+ Complexity      775      773       -2     
============================================
  Files           170      170              
  Lines         11948    11957       +9     
  Branches        250      250              
============================================
- Hits           7601     7598       -3     
- Misses         3770     3780      +10     
- Partials        577      579       +2
Flag Coverage Δ
java-unittests 80.07% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
control-plane/pkg/contract/contract.pb.go 7.41% <0.00%> (-0.04%) ⬇️
control-plane/pkg/reconciler/broker/broker.go 71.92% <100.00%> (+0.05%) ⬆️
control-plane/pkg/reconciler/channel/channel.go 69.10% <100.00%> (+0.05%) ⬆️
...ntrol-plane/pkg/reconciler/channel/v2/channelv2.go 70.96% <100.00%> (+0.04%) ⬆️
control-plane/pkg/reconciler/sink/kafka_sink.go 74.13% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2023
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 12, 2023

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 July 12, 2023 15:00
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 12, 2023

/retest

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2023
Cali0707
Cali0707 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 12, 2023

/retest

1 similar comment
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 13, 2023

/retest

This was referenced Jul 13, 2023
Closed
Merged
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 14, 2023

/cc @pierDipi
Ready to be merged

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2023
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2023
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Jul 26, 2023

/retest

@Leo6Leo Leo6Leo requested a review from pierDipi July 26, 2023 14:40
@pierDipi pierDipi changed the title Bump Vertx to 4.4.4 Bump Vertx to 4.4.3 Jul 26, 2023
pierDipi
pierDipi approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@knative-prow knative-prow bot merged commit 8f427c2 into knative-extensions:main Jul 26, 2023
16 of 18 checks passed
Rahul-Kumar-prog pushed a commit to Rahul-Kumar-prog/eventing-kafka-broker that referenced this pull request Jul 31, 2023
@Leo6Leo @Rahul-Kumar-prog
Bump Vertx to 4.4.3 (knative-extensions#3201)
608880b 
* Bump Quarkus to 3.1.2 Final (test failing)

* update the dependencies, and overwrite the antlr version

* Code-gen

* codegen

* Bump up vertx and coomplete codegen

* Code gen

* donwgrade to vertx4.4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Cali0707 Cali0707 Cali0707 approved these changes

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leo6Leo @pierDipi @Cali0707 @knative-prow-robot