Update the document to include the code formatter #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
Leo6Leo
commented
Jul 11, 2023
| @@ -44,7 +45,8 @@ export KO_DOCKER_REPO=docker.io/<username> | |||
|
|
|||
| _Note: replace `<username>` with your username._ | |||
|
|
|||
| In case you setup `KinD` via [./hack/create-kind-cluster.sh](hack/create-kind-cluster.sh), the local registry is available at `localhost:5001`: | |||
| In case you setup `KinD` via [./hack/create-kind-cluster.sh](hack/create-kind-cluster.sh), the local registry is | |||
| available at `localhost:5001`: | |||
There was a problem hiding this comment.
These changes are performed by the formatter.
knative-prow
bot
added
lgtm
pierDipi
reviewed
Jul 11, 2023
| directory: | ||
|
|
||
| ```shell | ||
| mvn spotless:apply |
There was a problem hiding this comment.
Technically this is better because we don't require a maven installation
Suggested change
| mvn spotless:apply | |
| ./mvnw spotless:apply |
There was a problem hiding this comment.
omg that's soo fast loll, haven't updated it yet and it got merged. Prow you did a great job
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, Leo6Leo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
merged commit c713604
into
knative-extensions:main
13 of 15 checks passed
Rahul-Kumar-prog
pushed a commit
to Rahul-Kumar-prog/eventing-kafka-broker
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166
Proposed Changes
Release Note