-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of KafkaProducer
from the dispatcher and use ReactiveKafkaProducer
instead
#3206
Remove the use of KafkaProducer
from the dispatcher and use ReactiveKafkaProducer
instead
#3206
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov Report
@@ Coverage Diff @@
## main #3206 +/- ##
============================================
+ Coverage 63.41% 63.47% +0.05%
- Complexity 747 762 +15
============================================
Files 167 169 +2
Lines 11815 11859 +44
Branches 246 246
============================================
+ Hits 7493 7527 +34
- Misses 3749 3759 +10
Partials 573 573
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
...er/src/test/java/dev/knative/eventing/kafka/broker/dispatcher/MockReactiveKafkaProducer.java
Outdated
Show resolved
Hide resolved
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debasishbsws, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa18175
into
knative-extensions:main
…veKafkaProducer` instead (knative-extensions#3206) * Move Reactive Inteefaces into core module * chenge ReactiveProducerFact to use in dispatche * remove vertx KafkaProducer from dispatcher * test module use vertx impl * spotless formating and codegen * Use ReceiverMock instead create new in dispatcher * Remove unnesessury THIRD-PARTY file change * remove not used constructor
Fixes #3191 and progress in #2928
Proposed Changes
A clean, without-conflict clone PR of #3192