Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E common setup does not wait for cert manager #3209

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix E2E common setup does not wait for cert manager #3209

merged 1 commit into from
Jul 19, 2023

Conversation

Rahul-Kumar-prog
Copy link
Contributor

@Rahul-Kumar-prog Rahul-Kumar-prog commented Jul 12, 2023 •
edited
Loading

Fixes #3182

Proposed Changes

Previously : E2E common setup does not wait for cert manager to become ready.

Now : E2E common setup wait for cert manager to become ready. Now its wait for all cert-manager pods to up and running.

Release Note

wait_until_pods_running

Output

Screenshot 2023-07-13 at 1 40 42 AM

@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

Welcome @Rahul-Kumar-prog! It looks like this is your first PR to knative-sandbox/eventing-kafka-broker 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

Hi @Rahul-Kumar-prog. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2023
@pierDipi
Copy link
Member

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 July 13, 2023 14:57
Cali0707
Cali0707 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing this @Rahul-Kumar-prog! 🎉

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@Cali0707
Copy link
Member

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi July 13, 2023 15:01
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #3209 (1175c89) into main (8a22c57) will decrease coverage by 16.47%.
The diff coverage is n/a.

❗ Current head 1175c89 differs from pull request most recent head 23045a5. Consider uploading reports for the commit 23045a5 to get more accurate results

@@              Coverage Diff              @@
##               main    #3209       +/-   ##
=============================================
- Coverage     79.88%   63.42%   -16.47%     
+ Complexity      753      747        -6     
=============================================
  Files            76      167       +91     
  Lines          2700    11815     +9115     
  Branches        246      246               
=============================================
+ Hits           2157     7494     +5337     
- Misses          396     3748     +3352     
- Partials        147      573      +426
Flag Coverage Δ
java-unittests 79.74% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 93 files with indirect coverage changes

@Cali0707
Copy link
Member

/retest-required

1 similar comment
@Cali0707
Copy link
Member

/retest-required

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@Rahul-Kumar-prog
Copy link
Contributor Author

@Cali0707 can you start tests again I think those errors comes because of the blank space.

@Cali0707
Copy link
Member

/retest-required

@Cali0707
Copy link
Member

/lgtm

/cc @creydr

@knative-prow knative-prow bot requested a review from creydr July 14, 2023 13:02
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@creydr
Copy link
Contributor

creydr commented Jul 17, 2023

/retest

creydr
creydr reviewed Jul 17, 2023
View reviewed changes
test/e2e-common.sh Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@Rahul-Kumar-prog
Copy link
Contributor Author

@creydr I did changes that you suggested.
please retest this.

@creydr
Copy link
Contributor

creydr commented Jul 18, 2023

/retest

creydr
creydr reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Waiting until all pods in namespace cert-manager are up....
All pods are up:
cert-manager-698dc8bdd5-fd6tq              1/1   Running   0     12s
cert-manager-cainjector-6db899f596-rk7cp   1/1   Running   0     12s
cert-manager-webhook-78489cc458-qtb4r      1/1   Running   0     12s
>> Install Knative Eventing from latest - ./third_party/eventing-latest/

Thanks @Rahul-Kumar-prog

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@pierDipi
Copy link
Member

/approve

@knative-prow
Copy link

knative-prow bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi, Rahul-Kumar-prog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@pierDipi
Copy link
Member

/test channel-integration-tests-sasl-ssl

@knative-prow knative-prow bot merged commit 05694b6 into knative-extensions:main Jul 19, 2023
Rahul-Kumar-prog added a commit to Rahul-Kumar-prog/eventing-kafka-broker that referenced this pull request Jul 31, 2023
@Rahul-Kumar-prog
Fix E2E Common Setup Now Its Wait For Cert manager (knative-extension…
1a4204c 
…s#3209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@Cali0707 Cali0707 Cali0707 approved these changes

@matzew matzew Awaiting requested review from matzew

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@creydr creydr

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E common setup does not wait for cert manager to become ready
4 participants
@Rahul-Kumar-prog @pierDipi @Cali0707 @creydr