Expose OIDC audience of KafkaSink in its status #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
area/control-plane
area/test
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4067 +/- ##
==========================================
+ Coverage 48.33% 48.37% +0.04%
==========================================
Files 244 244
Lines 14579 14591 +12
==========================================
+ Hits 7047 7059 +12
Misses 6821 6821
Partials 711 711 ☔ View full report in Codecov by Sentry. |
|
/test integration-tests |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
|
/retest-required |
where did you see those? |
|
/test upgrade-tests |
|
@creydr: new pull request created: #4071 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@creydr: new pull request created: #4072 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
creydr
added a commit
to creydr/knative-eventing-kafka-broker
that referenced
this pull request
Aug 20, 2024
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Expose OIDC audience of KafkaSink in its status (#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
knative-prow-robot
pushed a commit
to knative-prow-robot/eventing-kafka-broker
that referenced
this pull request
Aug 26, 2024
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
* Expose OIDC audience of KafkaSink in its status (#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue --------- Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
creydr
added a commit
to creydr/knative-eventing-kafka-broker
that referenced
this pull request
Aug 26, 2024
…ve-extensions#4073) * Expose OIDC audience of KafkaSink in its status (knative-extensions#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
creydr
added a commit
to creydr/knative-eventing-kafka-broker
that referenced
this pull request
Sep 4, 2024
…ve-extensions#4073) * Expose OIDC audience of KafkaSink in its status (knative-extensions#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Sep 9, 2024
…ve-extensions#4073) (#1166) * Expose OIDC audience of KafkaSink in its status (knative-extensions#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
creydr
added a commit
to creydr/knative-eventing-kafka-broker
that referenced
this pull request
Sep 10, 2024
…ve-extensions#4073) * Expose OIDC audience of KafkaSink in its status (knative-extensions#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
pierDipi
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Sep 12, 2024
…ve-extensions#4073) (#1162) * Expose OIDC audience of KafkaSink in its status (knative-extensions#4067) * Provision audience of KafkaSink * Add e2e test * Run full OIDC e2e test suite * run gofmt and goimports * Fix build issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
.status.address.audienceand.status.addresses[*].audiencefield/cherry-pick release-1.15
/cherry-pick release-1.14