Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use istio inject label #4115

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Use istio inject label #4115

merged 1 commit into from
Oct 2, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi
Use istio inject label
f39d26c 
Ref: knative/eventing#8204

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added area/control-plane area/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.44%. Comparing base (545216c) to head (f39d26c).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4115   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files         244      244           
  Lines       14876    14876           
=======================================
  Hits         7207     7207           
  Misses       6942     6942           
  Partials      727      727

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/retest-required

matzew
matzew approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi pierDipi mentioned this pull request Sep 26, 2024
Closed
@matzew
Copy link
Contributor

matzew commented Sep 26, 2024

/test reconciler-tests

@matzew
Copy link
Contributor

matzew commented Sep 27, 2024

/retest

@pierDipi
Copy link
Member Author

/test reconciler-tests

1 similar comment
@pierDipi
Copy link
Member Author

pierDipi commented Oct 1, 2024

/test reconciler-tests

@pierDipi
Copy link
Member Author

pierDipi commented Oct 1, 2024

/test upgrade-tests

@pierDipi
Copy link
Member Author

pierDipi commented Oct 2, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Oct 2, 2024

/retest

@knative-prow knative-prow bot merged commit b9233fe into knative-extensions:main Oct 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @matzew