Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add languages command to cmd root #1127

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

lance
Copy link
Member

@lance lance commented Jul 19, 2022

This command does not get surfaced to the user without adding it to the root.
Also add a little more information to the short description.

Signed-off-by: Lance Ball lball@redhat.com

Also add a little more information to the short description.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1127 (55df1b9) into main (b1fd9f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files          65       65           
  Lines        8701     8702    +1     
=======================================
+ Hits         3993     3994    +1     
  Misses       4321     4321           
  Partials      387      387           
Impacted Files Coverage Δ
cmd/languages.go 90.32% <100.00%> (ø)
cmd/root.go 75.19% <100.00%> (+0.09%) ⬆️

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@knative-prow knative-prow bot merged commit 59df756 into knative:main Jul 20, 2022
@lance lance added this to the 0.26.0 Release milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants