Improve func config envs

[matejvasek]

Changes

• 🎁 Added ability to add env non-interactively via flags
• 🎁 Added ability to list envs as JSON

/kind enhancement

feat: added ability to add env non-interactively via flags and to list envs as JSON

[knative-prow]

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

• Added ability to add env non-interactively
• Added ability to list envs as JSON

Signed-off-by: Matej Vasek mvasek@redhat.com

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1188 (c88cb98) into main (cd64b70) will increase coverage by 0.24%.
The diff coverage is 71.73%.

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   44.92%   45.17%   +0.24%     
==========================================
  Files          68       68              
  Lines        9698     9745      +47     
==========================================
+ Hits         4357     4402      +45     
- Misses       4941     4942       +1     
- Partials      400      401       +1     

Impacted Files	Coverage Δ
cmd/config_volumes.go	25.64% <0.00%> (ø)
cmd/config_envs.go	25.32% <72.00%> (+10.39%)	⬆️
cmd/config.go	30.27% <80.00%> (+0.18%)	⬆️
cmd/config_labels.go	70.45% <100.00%> (ø)
cmd/root.go	75.19% <100.00%> (-0.39%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[matejvasek]

@lance @lkingland @zroubalik PTAL

[lance]

Looks good overall. Thanks! Can you add an example to ConfigEnvsAddCmd() help text so that we the configMap syntax is shown? Also, I don't see a test for secret - is that also possible? Perhaps a test and doc for that as well?

[lkingland]

Looks good to me as well. Lance brings up some good points. My only question was about changing to use the simplified flag --json rather than the key/value output=[x] approach we started with some time ago.

/lgtm
/hold for Lance's suggestions

[matejvasek]

Also, I don't see a test for secret - is that also possible? Perhaps a test and doc for that as well?

@lance Actually even test for configMap is overkill here, everything is handled as string here (no special cases for configMap or secrets). Magic happens in deploy phase.

[lance]

Also, I don't see a test for secret - is that also possible? Perhaps a test and doc for that as well?

@lance Actually even test for configMap is overkill here, everything is handled as string here (no special cases for configMap or secrets). Magic happens in deploy phase.

Fair enough - but how about an example in func config envs add help text?

[matejvasek]

/override style / Lint

[knative-prow]

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators.

In response to this:

/override style / Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matejvasek]

@lance PTAL

[matejvasek]

@lance also I need override /override style / Lint

[matejvasek]

@lance the override shouldn't be needed now after docgen update.

[zroubalik]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland,matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

/unhold