fix: check for --image flag in build command
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provides an `--image` flag on the command line, it should be used. This commit modifies the image resolving code to check whether or not the image name was provided on the command line. Fixes: knative#1125 Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow
bot
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 45.20% 45.23% +0.03%
==========================================
Files 68 68
Lines 9745 9746 +1
==========================================
+ Hits 4405 4409 +4
+ Misses 4940 4938 -2
+ Partials 400 399 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lkingland
approved these changes
Aug 31, 2022
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lance Ball <lball@redhat.com>
|
/lgtm |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--imageflag in build commandIf the user provides an
--imageflag on the command line, it should be used. This commit modifies the image resolving code to check whether or not the image name was provided on the command line.Fixes: #1125
/kind bug
Release Note