Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing two sources(brokers) and third invocation for an override on the first #2118

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Jan 16, 2024

Changes

  • 🧹 Enhancing test coverage of a different scenario

/kind

Fixes #

Release Note


Docs


…n the first

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link

knative-prow bot commented Jan 16, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Enhancing test coverage of a different scenario

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b29f702) 64.24% compared to head (b8c04f9) 65.18%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
+ Coverage   64.24%   65.18%   +0.94%     
==========================================
  Files         108      108              
  Lines       13888    13888              
==========================================
+ Hits         8922     9053     +131     
+ Misses       4098     3942     -156     
- Partials      868      893      +25     
Flag Coverage Δ
e2e-test 37.37% <ø> (+0.05%) ⬆️
e2e-test-oncluster 30.54% <ø> (ø)
e2e-test-oncluster-runtime 26.80% <ø> (?)
e2e-test-runtime-go 25.52% <ø> (?)
e2e-test-runtime-node 26.54% <ø> (?)
e2e-test-runtime-python 26.54% <ø> (?)
e2e-test-runtime-quarkus 26.65% <ø> (?)
e2e-test-runtime-rust 25.54% <ø> (?)
e2e-test-runtime-springboot 25.68% <ø> (?)
e2e-test-runtime-typescript 26.65% <ø> (?)
integration-tests 51.85% <ø> (+1.99%) ⬆️
unit-tests-macos-latest 48.84% <ø> (ø)
unit-tests-ubuntu-latest 49.57% <ø> (?)
unit-tests-windows-latest 48.89% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
Copy link

knative-prow bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@knative-prow knative-prow bot merged commit 6c32213 into knative:main Jan 16, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants