Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of only proper handler API, no longer need for redundant Context #2249

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Mar 26, 2024

Changes

  • 🧹 Update temple doc, based on recent changes around their signature

/kind

Fixes #

Release Note


Docs


Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link

knative-prow bot commented Mar 26, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • 🧹 Update temple doc, based on recent changes around their signature

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link

knative-prow bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"

Copy link

knative-prow bot commented Mar 26, 2024

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • On Cluster RT Test (ubuntu-latest, pack) (pull_request)

Only the following failed contexts/checkruns were expected:

  • E2E Test (rust)
  • EasyCLA
  • On Cluster RT Test (ubuntu-latest, pack)
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Mar 26, 2024

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • On Cluster RT Test (ubuntu-latest, pack) (pull_request)

Only the following failed contexts/checkruns were expected:

  • E2E Test (rust)
  • EasyCLA
  • On Cluster RT Test (ubuntu-latest, pack)
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "On Cluster RT Test (ubuntu-latest, pack) (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

/override "On Cluster RT Test (ubuntu-latest, pack)"

Copy link

knative-prow bot commented Mar 26, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: On Cluster RT Test (ubuntu-latest, pack)

In response to this:

/override "On Cluster RT Test (ubuntu-latest, pack)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor

@ReToCode we need to override also "E2E Test (rust) (pull_request)"

@ReToCode
Copy link
Member

/override "E2E Test (rust) (pull_request)"

Copy link

knative-prow bot commented Mar 26, 2024

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • E2E Test (rust) (pull_request)

Only the following failed contexts/checkruns were expected:

  • E2E Test (rust)
  • EasyCLA
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "E2E Test (rust) (pull_request)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

/override "E2E Test (rust)"

Copy link

knative-prow bot commented Mar 26, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: E2E Test (rust)

In response to this:

/override "E2E Test (rust)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 8ced626 into knative:main Mar 26, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants