Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: func config volumes - interactive prompt #391

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jun 16, 2021

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Interactive prompt for managing function configuration - this PR adds Volumes (Envs will be in a separate PR).

func config - starts interactive prompt, wizard that let's you select resource and the requested operation

func config volumes - list configured Volumes

func config volumes add - starts interactive prompt, wizard that let's you add Volume mount to the configuration. It does a lookup for existing Secrets and ConfigMaps in the cluster and namespace.

func config volumes remove - starts interactive prompt, wizard that let's you remove Volume mount from the configuration.

Relates: #362

@zroubalik
Copy link
Contributor Author

func_config_volumes.mp4

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looking forward to using this flow elsewhere. Like Lance said, this is a strong example of how func doesn't fit entirely into a plugin box.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

cmd/config.go Show resolved Hide resolved
cmd/config_volumes.go Outdated Show resolved Hide resolved
cmd/config_volumes.go Outdated Show resolved Hide resolved
@lance
Copy link
Member

lance commented Jun 16, 2021

Nice. Looking forward to using this flow elsewhere. Like Lance said, this is a strong example of how func doesn't fit entirely into a plugin box.

Yes! I would like to update #373 to use this flow for labels.

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik merged commit 4ba95b6 into knative:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants