doc: expand on language pack documentation #545
Conversation
Adds more detail around how language packs can be provided by third parties, and the expected structure and metadata required. Fixes: knative#452 Signed-off-by: Lance Ball <lball@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
| └── test.rb | ||
| ``` | ||
|
|
||
| ## `manifest.yaml` |
There was a problem hiding this comment.
I thought that manifest.yaml would be placed at the Language Pack Repository Root. Basically, at the URL which is provided to func repository add. If func searches for a manifest.yaml at that URL (the repository's manifest), then the developer of the Language Pack would be free to place all their runtimes in a subdirectory. Are we talking about the same manifest.yaml? The above seems like it might be for a single template specifically?
Regardig a repo-root manifest, we could look for a manifest.yaml at URL provided to func repo add, and within that manifest look for a 'templates: <path>' entry which specifies a repository-relative path to use for runtimes/templates as an override to the default behavior of using file structure. To make things even easier, we could automatically use a directory 'templates' if that exists.
knative-prow-robot
added
the
do-not-merge/work-in-progress
|
Closing this. Changes here have been copied to #558 and updated. |
Changes
Adds more detail around how language packs can be provided by third parties, and the expected structure and metadata required. Creating as WIP pending additional discussion and possible implementation of #452
/kind documentation
Fixes: #452