Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: CheckAuth() calls registry directly #704

Merged
merged 1 commit into from
Dec 7, 2021
Merged

src: CheckAuth() calls registry directly #704

merged 1 commit into from
Dec 7, 2021

Conversation

matejvasek
Copy link
Contributor

CheckAuth() calls registry directly not using docker daemon as a middle-man.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 6, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2021
@matejvasek matejvasek requested a review from lance December 6, 2021 19:46
@codecov
Copy link

codecov bot commented Dec 6, 2021 •
edited
Loading

Codecov Report

Merging #704 (19c219a) into main (79ad65d) will increase coverage by 0.30%.
The diff coverage is 69.23%.

❗ Current head 19c219a differs from pull request most recent head 4ade025. Consider uploading reports for the commit 4ade025 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   39.48%   39.79%   +0.30%     
==========================================
  Files          42       42              
  Lines        3948     3968      +20     
==========================================
+ Hits         1559     1579      +20     
+ Misses       2172     2168       -4     
- Partials      217      221       +4
Impacted Files Coverage Δ
docker/pusher.go 39.39% <69.23%> (+7.42%) ⬆️
cmd/root.go 59.25% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ad65d...4ade025. Read the comment docs.

@matejvasek
src: CheckAuth() calls registry directly
4ade025 
CheckAuth() calls registry directly
not using docker daemon as a middle-man

Signed-off-by: Matej Vasek <mvasek@redhat.com>
zroubalik
zroubalik reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice! I like that we are moving away from docker/cli

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

@zroubalik would you /lgtm?

@zroubalik
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2021
@knative-prow-robot knative-prow-robot merged commit fcb0c71 into knative:main Dec 7, 2021
@matejvasek matejvasek mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@lkingland lkingland Awaiting requested review from lkingland

@lance lance Awaiting requested review from lance

Assignees

@zroubalik zroubalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @knative-prow-robot @zroubalik