Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: revert global dialer #716

Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Dec 10, 2021

Fixes: #715

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #716 (d5cacbe) into main (a13f897) will decrease coverage by 0.05%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   39.98%   39.93%   -0.06%     
==========================================
  Files          42       42              
  Lines        3981     3986       +5     
==========================================
  Hits         1592     1592              
- Misses       2167     2172       +5     
  Partials      222      222              
Impacted Files Coverage Δ
cmd/emit.go 35.48% <0.00%> (-2.02%) ⬇️
cloudevents/emitter.go 62.96% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13f897...d5cacbe. Read the comment docs.

@matejvasek matejvasek changed the title src: revert golobal dialer src: revert global dialer Dec 10, 2021
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for CI

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@lance
Copy link
Member

lance commented Dec 10, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2021
@knative-prow-robot knative-prow-robot merged commit 6c67be0 into knative:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing global HTTP override
3 participants