refactor encoding tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to use the mocked interner see comments in `tests/encode.rs` for details the tests that were in `/src/tests.rs` have been moved into `tests/encode.rs`
japaric
commented
Jul 30, 2020
tests/encode.rs
Outdated
| // CFI = Check Format Implementation | ||
| fn cfi(val: impl Format, bytes: &[u8]) { | ||
| let mut f = Formatter::new(); | ||
| let index = fetch_string_index(); |
There was a problem hiding this comment.
wondering if not implicitly checking the index inside cfi may make things easier to read.
instead of that index would need to be included in the bytes argument
1/3
There was a problem hiding this comment.
After reading the tests I think I agree that this would be better
There was a problem hiding this comment.
ok, I'll change this later
tests/encode.rs
Outdated
| cfi( | ||
| X { y: 1, z: 2 }, | ||
| &[ | ||
| 1, // x |
There was a problem hiding this comment.
this one would change for example and require an index at the start so it would look like this:
cfi(
X { y: 1, z: 2 },
&[
+ index, // "X { y: {{:u8}}, z: {{:u16}} }"
1, // x
2, // y.low
0, // y.high
],
)2/3
tests/encode.rs
Outdated
|
|
||
| #[test] | ||
| fn format_primitives() { | ||
| cfi(42u8, &[42]); |
There was a problem hiding this comment.
these tests would become way longer with that change though 3/3
|
Updated with explicit index in the expected bytes argument. |
jonas-schievink
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use the mocked interner
see comments in
tests/encode.rsfor detailsthe tests that were in
/src/tests.rshave been moved intotests/encode.rs