Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt-in binfmt decoding #112

Merged
merged 3 commits into from
Aug 13, 2020
Merged

opt-in binfmt decoding #112

merged 3 commits into from
Aug 13, 2020

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 13, 2020

  • probe-run: adds --binfmt flag to pick between binfmt decoding and no decoding
  • probe-run: adds "binfmt" Cargo feature to make binfmt dependencies and the above flag optional

if table.is_none() && opts.binfmt {
bail!(".`.binfmt` section not found")
} else if table.is_some() && !opts.binfmt {
eprintln!("warning: application may be using `binfmt` but `--binfmt` flag was not used");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@japaric japaric merged commit 4320ff6 into main Aug 13, 2020
@jonas-schievink jonas-schievink deleted the opt-in-binfmt branch October 19, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants