Add parser support for bitfields #13

jonas-schievink · 2020-07-30T14:45:34Z

No description provided.

japaric

Thanks; looks good to me. For now let's also reject ranges that try to view outside a 32-bit value, e.g. {:31..33}.

japaric · 2020-07-30T14:54:38Z

parser/src/lib.rs

    #[test]
    fn range() {
-        assert!(super::parse("{:0..4}").is_ok());
+        let fmt = "{:0..4}";


Also, could add some tests that exercise indexed parameters? "{0:0..4} {0:2..6}" (it's OK if the bitfield slices overlap). Also something with different indices: "{0:0..4} {1:8..12}".

323: Merge I128/Ixx and U128/Uxx variants r=japaric a=Sh3Rm4n Closes #314 Also lift 32 bit range for bitfields introduced in #13 Could be split into another PR, if concerns are raised. Co-authored-by: Fabian Viöl <f.vioel@googlemail.com>

Add parser support for bitfields

0fecacb

japaric approved these changes Jul 30, 2020

View reviewed changes

japaric reviewed Jul 30, 2020

View reviewed changes

Allow different bitfield ranges, improve tests

ea5de9d

japaric merged commit e16e082 into main Jul 30, 2020

jonas-schievink deleted the parse-bitfields branch July 30, 2020 15:31

Sh3Rm4n mentioned this pull request Dec 20, 2020

Merge I128/Ixx and U128/Uxx variants #323

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parser support for bitfields #13

Add parser support for bitfields #13

jonas-schievink commented Jul 30, 2020

japaric left a comment

japaric Jul 30, 2020

Add parser support for bitfields #13

Add parser support for bitfields #13

Conversation

jonas-schievink commented Jul 30, 2020

japaric left a comment

Choose a reason for hiding this comment

japaric Jul 30, 2020

Choose a reason for hiding this comment