New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix impl Format for Str (interned string) #166

Merged

japaric merged 1 commit into main from gh164

Sep 7, 2020

Member

japaric commented Sep 7, 2020

closes #164


          fix impl Format for Str (interned string)

c41d67e

closes #164

japaric commented

View reviewed changes

src/impls.rs

@@ @@ -93,7 +93,7 @@ impl Format for f32 { @@
               impl Format for Str {
                   fn format(&self, fmt: &mut Formatter) {
                       if fmt.needs_tag() {
-                          let t = internp!("{:str}");
+                          let t = internp!("{:istr}");

Member Author

japaric Sep 7, 2020

we forgot to update this format string when we renamed {:str} to {:istr} some time ago

jonas-schievink approved these changes

View reviewed changes

japaric merged commit 3a0232e into main

jonas-schievink deleted the gh164 branch

October 19, 2020 15:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet