store raw symbols in decoder::Table #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the raw symbols are used to check if a symbol is "live" when extracting location information from dwarf fixes location information
japaric
commented
Oct 19, 2020
decoder/src/lib.rs
Outdated
| @@ -113,8 +133,9 @@ impl Table { | |||
| self.entries.is_empty() | |||
| } | |||
|
|
|||
| /// Iterates over the raw symbols of the table entries | |||
| pub fn symbols<'s>(&'s self) -> impl Iterator<Item = &'s str> + 's { | |||
There was a problem hiding this comment.
this method relies on Item being a 'raw symbol' (as it appears in the .symtab)
There was a problem hiding this comment.
We could rename it to raw_symbols if that doesn't cause too much churn, to make it a bit clearer
japaric
merged commit f745993
into
cursed-symbol-names-linkers-must-repent-for-their-sins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the raw symbols are used to check if a symbol is "live" when extracting location information from dwarf
fixes location information in PR #175