macros. implement other logging levels #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macros/src/lib.rs
Outdated
| @@ -250,7 +317,33 @@ pub fn info(ts: TokenStream) -> TokenStream { | |||
| .into() | |||
| } | |||
|
|
|||
| // TODO share more code with `info` | |||
| // TODO other logging levels | |||
There was a problem hiding this comment.
Are there any left to add?
There was a problem hiding this comment.
nope, good catch!
japaric
approved these changes
Jul 31, 2020
- extend macros with trace, debug, warn and error log levels - add compile test - add example usage to firmware/log.rs
Lotterleben
force-pushed
the
warn_err_debug_info
branch
from
dac7264
to
c2f0148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paired with @jonas-schievink
Add
trace,debug,warnanderrorlog levels and fix log level handling.Also adds a tiny compile test to at least ensure future US won't break anything.
Extends
firmwareto demonstrate different log levels.To manually check, play around with the
default = ["binfmt-xx"]setting infirmware/Cargo.tomland run emulation infirmware.resolves #17
fixes #16
will squash after approval :)