Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Format trait docs #332

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Improve Format trait docs #332

merged 1 commit into from
Jan 12, 2021

Conversation

jonas-schievink
Copy link
Contributor

Closes #330

japaric
japaric approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@japaric
Copy link
Member

japaric commented Jan 12, 2021

bors r+

bors bot added a commit that referenced this pull request Jan 12, 2021
@bors @jonas-schievink
Merge #332
53f9679 
332: Improve `Format` trait docs r=japaric a=jonas-schievink

Closes #330

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 12, 2021

Build failed:

@japaric
Copy link
Member

japaric commented Jan 12, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 12, 2021

Build succeeded:

@bors bors bot merged commit 9410343 into main Jan 12, 2021
@bors bors bot deleted the format-docs branch January 12, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples on custom implementation of the Format trait.
2 participants
@jonas-schievink @japaric