Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy clippy #367

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Satisfy clippy #367

merged 2 commits into from
Feb 3, 2021

Conversation

Urhengulas
Copy link
Member

Fix multiple clippy warnings:

  • useless conversion to the same type: u128
  • useless use of format!
  • called .as_ref().map(|s| &**s) on an Option value. This can be done more directly by calling mod_path.as_deref() instead
  • you seem to be trying to use match for destructuring a single pattern. Consider using if let

Surpress:

  • returning an Err(_) with the ? operator

@Urhengulas Urhengulas self-assigned this Feb 3, 2021
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But we can fix the last warning too

print/src/main.rs Outdated Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 3, 2021

Build succeeded:

@bors bors bot merged commit d317f82 into main Feb 3, 2021
@bors bors bot deleted the satisfy-clippy branch February 3, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants