internp: fix 'section specifier' compiling err on mac os #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
requested changes
Jul 30, 2020
There was a problem hiding this comment.
The changes in macros look good but cargo-building binfmt from the root fails with:
let t = internp!(".."); // error: use of undeclared type or module `binfmt`We'll need to re-export crate as binfmt in src/impls.rs as done in https://github.com/ferrous-systems/binfmt/blob/751a006b9d1ba077f5f31acc1e3a983fb111c75d/src/lib.rs#L12
|
done |
|
one more thing: I have just merged the CI PR. Could you rebase and uncomment the macOS builder? |
japaric
approved these changes
Jul 30, 2020
Lotterleben
force-pushed
the
build_mac_os
branch
from
f45e567
to
44b9842
Compare
japaric
pushed a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.