Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the backwards-compatiblity check #403

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Add back the backwards-compatiblity check #403

merged 2 commits into from
Feb 22, 2021

Conversation

jonas-schievink
Copy link
Contributor

Should fix #295

@jonas-schievink
Copy link
Contributor Author

Looks like CI passed 🎉

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

CARGO_TARGET_THUMBV7M_NONE_EABI_RUNNER: qemu-run
QEMU_RUN_IGNORE_VERSION: 1
run: |
cargo install --debug --git https://github.com/knurling-rs/defmt --rev 7814e1c qemu-run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you tag this revision so it's more clear that it is v0.2.0 plus the the new QEMU_RUN_IGNORE_VERSION. (I guess next time we'll be able to directly use v0.3.0 here)

@japaric
Copy link
Member

japaric commented Feb 22, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 22, 2021

Build succeeded:

@bors bors bot merged commit 0aa637a into knurling-rs:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update and re-enable qemu backwards-compatibility test
2 participants