Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unstable-test on docs.rs #413

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Disable unstable-test on docs.rs #413

merged 1 commit into from
Feb 26, 2021

Conversation

jonas-schievink
Copy link
Contributor

@Urhengulas
Copy link
Member

How can one test if this configuration works?

@jonas-schievink
Copy link
Contributor Author

I tested this locally. I'm not aware of any convenient ways to test it in CI.

@jonas-schievink
Copy link
Contributor Author

I ran:

env RUSTDOCFLAGS=--cfg=docsrs cargo +nightly doc --features alloc --target thumbv6m-none-eabi --open

Replacing the --features alloc with --all-features reproduces the error on docs.rs.

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
By the way, was what the reason for specifying thumbv6 and thumbv7 as the docs.rs targets? we don't cfg public API based on the target (architecture), right? (impl Format for Arc doesn't exist on thumbv6 but Arc doesn't exist there either)

@jonas-schievink
Copy link
Contributor Author

impl Format for Arc doesn't exist on thumbv6 but Arc doesn't exist there either

It does exist on thumbv7, so it will show up in the docs for thumbv7

@jonas-schievink
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 26, 2021

Build succeeded:

@bors bors bot merged commit 9840b3e into knurling-rs:main Feb 26, 2021
@jonas-schievink jonas-schievink deleted the fix-docsrs branch March 5, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants