Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make elf2table::Location public #415

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Make elf2table::Location public #415

merged 1 commit into from
Feb 26, 2021

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Feb 25, 2021

Table::get_locations returns Locations which is not public. The Location type seems pretty safe to make public. There should at least be a public opaque type so the result of get_locations can be passed between functions.

@mattico mattico mentioned this pull request Feb 25, 2021
Merged
@Urhengulas
Copy link
Member

Sounds good to me! Though be aware that defmt_decoder is still unstable and is subject to change.

bors r+

@Urhengulas
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 26, 2021

Already running a review

@bors
Copy link
Contributor

bors bot commented Feb 26, 2021

Build succeeded:

@bors bors bot merged commit 22a9959 into knurling-rs:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattico @Urhengulas