Add leading zeros support. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok need to fix up some tests |
|
Would you mind setting off the CI again? |
Urhengulas
requested changes
May 10, 2021
Urhengulas
reviewed
May 12, 2021
|
Could anyone help me understand the output from the qemu test? |
What do you mean? |
Urhengulas
requested changes
May 12, 2021
|
Made requested changes. |
|
Awesome! Please rebase and then we can merge (if you "allow edit from maintainers" i can also do this for you, see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) |
derekdreery
force-pushed
the
leading_zeros
branch
from
1de73dd
to
106858e
Compare
|
Squashed and rebased. You should already have the ability to edit this PR (the box is ticked). |
|
bors r+ |
|
Thank you for the PR @derekdreery! Feel free to send your PR for |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for things like
info!("{=u16:08X}", 42"). It is tested in the mdbook.I could have added precision support as well, but I figure floats aren't so often used on embedded, whereas printing out a
u32nicely aligned is a common task.