Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse trailing commas in most macros #47

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Parse trailing commas in most macros #47

merged 1 commit into from
Aug 4, 2020

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Aug 4, 2020 •
edited
Loading

Notable exception: intern!. But I think it makes sense to have that just accept a single string literal token.

Fixes #44

japaric
japaric approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@japaric japaric merged commit 31e5116 into main Aug 4, 2020
@jonas-schievink jonas-schievink deleted the trailing-comma branch August 4, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macros don't support trailing commas
2 participants
@jonas-schievink @japaric