Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtask: fn utils::run_capturing_stdout #476

Merged
merged 6 commits into from
May 28, 2021
Merged

xtask: fn utils::run_capturing_stdout #476

merged 6 commits into from
May 28, 2021

Conversation

Urhengulas
Copy link
Member

Fix #452

@Urhengulas
Copy link
Member Author

See https://github.com/knurling-rs/defmt/runs/2587873002?check_suite_focus=true#step:5:96 for CI error

@Urhengulas Urhengulas force-pushed the fix-452 branch 2 times, most recently from f6dd6db to bff60da Compare May 21, 2021 12:19
@Urhengulas
Copy link
Member Author

Urhengulas commented May 27, 2021 •
edited
Loading

status:

  • handle that defmt-test seems to return non-zero exit codes for #[should_error] tests
  • give an error message better than Error (see above)

@Urhengulas Urhengulas force-pushed the fix-452 branch 3 times, most recently from 9858787 to 9689bc5 Compare May 27, 2021 21:50
@Urhengulas Urhengulas requested review from spookyvision and removed request for jonas-schievink May 27, 2021 22:14
Lotterleben
Lotterleben approved these changes May 28, 2021
View reviewed changes
xtask/src/utils.rs Outdated Show resolved Hide resolved
xtask/src/utils.rs Outdated Show resolved Hide resolved
Urhengulas and others added 2 commits May 28, 2021 16:36
@Urhengulas
xtask::utils: Fix typo
89755fa 
Co-authored-by: Lotte Steenbrink <lotte.steenbrink@ferrous-systems.com>
@Urhengulas
xtask::utils: Fix typo
f75443a 
Co-authored-by: Lotte Steenbrink <lotte.steenbrink@ferrous-systems.com>
@Urhengulas
Copy link
Member Author

bors r+

@Urhengulas
Copy link
Member Author

Thanks for the review @Lotterleben! 😊

@bors
Copy link
Contributor

bors bot commented May 28, 2021

Build succeeded:

@bors bors bot merged commit a723e61 into main May 28, 2021
@bors bors bot deleted the fix-452 branch May 28, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lotterleben Lotterleben Lotterleben approved these changes

@spookyvision spookyvision Awaiting requested review from spookyvision

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot tests are failing without an error message
2 participants
@Urhengulas @Lotterleben