Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.rs: Obtain version from macro; simplify #518

Merged
merged 3 commits into from
Jul 19, 2021
Merged

build.rs: Obtain version from macro; simplify #518

merged 3 commits into from
Jul 19, 2021

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Jun 23, 2021 •
edited
Loading

Fixes #517.

@jonas-schievink jonas-schievink added the pr waits on: author Pull Request requires changes from the author label Jun 24, 2021
@Urhengulas Urhengulas removed the pr waits on: author Pull Request requires changes from the author label Jun 29, 2021
@Urhengulas Urhengulas force-pushed the simplify-build branch 2 times, most recently from efbc57c to 562aa8c Compare June 30, 2021 11:43
@Urhengulas Urhengulas requested a review from japaric June 30, 2021 11:52
@Urhengulas Urhengulas marked this pull request as ready for review June 30, 2021 11:53
@Urhengulas Urhengulas requested review from Lotterleben and removed request for japaric June 30, 2021 11:55
@Urhengulas Urhengulas assigned Lotterleben and unassigned japaric Jun 30, 2021
@Urhengulas
Copy link
Member Author

I am a bit unsure if setting QEMU_RUN_IGNORE_VERSION: 1 for the whole snapshot job is what we want, but I don't see why not.

@Lotterleben
Copy link
Contributor

why "Might"?

@Urhengulas
Copy link
Member Author

why "Might"?

I still had the question if we want to replace whole build.rs with this change. This good resolved with jorge in the issue.

Lotterleben
Lotterleben approved these changes Jul 6, 2021
View reviewed changes
build.rs Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@Urhengulas
Copy link
Member Author

I will test this a bit to make sure it doesn't create a lot of version-mismatch errors.

@Urhengulas Urhengulas added the pr waits on: author Pull Request requires changes from the author label Jul 7, 2021
@Urhengulas Urhengulas force-pushed the simplify-build branch 2 times, most recently from 43ff436 to 8ee41d7 Compare July 19, 2021 13:26
@Urhengulas
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 19, 2021

Build succeeded:

@bors bors bot merged commit 7d5aaed into main Jul 19, 2021
@bors bors bot deleted the simplify-build branch July 19, 2021 13:31
@Urhengulas Urhengulas mentioned this pull request Jul 20, 2021
Merged
bors bot added a commit that referenced this pull request Jul 20, 2021
@bors @Urhengulas
Merge #545
05e0c66 
545: Revert "`build.rs`: Obtain version from macro; simplify" r=Urhengulas a=Urhengulas

Reverts #518

Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
@Urhengulas Urhengulas mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lotterleben Lotterleben Lotterleben approved these changes

Assignees

@Lotterleben Lotterleben

Labels
pr waits on: author Pull Request requires changes from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obtain git hash from git_version crate
4 participants
@Urhengulas @Lotterleben @jonas-schievink @japaric