Fix error message in case of version-mismatch #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the error message more meaningful. Currently it tells you probe-run supports defmt X while the firmware supports defmt Y, which is reasonable. But the substitution then tells you to install a version of probe-run that supports X (the version you're already using), which is contradictory, since Y (firmware supported version) is the real version you need to install for.
|
Exact error output prior to this change: |
|
Good catch! bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 14, 2021
626: Update mod.rs r=Urhengulas a=bobmcwhirter Make the error message more meaningful. Currently it tells you probe-run supports defmt X while the firmware supports defmt Y, which is reasonable. But the substitution then tells you to install a version of probe-run that supports X (the version you're already using), which is contradictory, since Y (firmware supported version) is the real version you need to install for. Co-authored-by: Bob McWhirter <bmcwhirt@redhat.com>
|
bors cancel |
|
Canceled. |
Urhengulas
changed the title
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the error message more meaningful.
Currently it tells you probe-run supports defmt X while the firmware supports defmt Y, which is reasonable. But the substitution then tells you to install a version of probe-run that supports X (the version you're already using), which is contradictory, since Y (firmware supported version) is the real version you need to install for.