make defmt::flush an no-operation when unstable-test feature is enabled #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that feature is only enabled when running the test suite
defmt::flush was causing linker errors ("undefined symbol _defmt_acquire") on Windows with Rust
1.59.0+ when defmt is built with 'unstable-test' enabled. the linker errors are not observed in
binary builds that link to defmt
this commit removes the symbol dependencies to _defmt_acquire, etc. when 'unstable-test' is enabled
jonathanpallant
approved these changes
Mar 10, 2022
|
bors r=jonathanpallant |
|
Build succeeded: |
|
I honestly still don't understand why this was a problem for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that feature is only enabled when running the test suite
defmt::flush was causing linker errors ("undefined symbol _defmt_acquire") on Windows with Rust
1.59.0+ when defmt is built with 'unstable-test' enabled. the linker errors are not observed in
binary builds that link to defmt when the feature is disabled
this commit removes the symbol dependencies to _defmt_acquire, etc. when 'unstable-test' is enabled