Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire format is still unstable #77

Merged
merged 1 commit into from
Aug 7, 2020
Merged

wire format is still unstable #77

merged 1 commit into from
Aug 7, 2020

Conversation

japaric
Copy link
Member

@japaric japaric commented Aug 7, 2020

No description provided.

Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, could we put a version in the symbols to enforce this?

@japaric japaric merged commit 7f594c9 into main Aug 7, 2020
@japaric
Copy link
Member Author

japaric commented Aug 7, 2020

In principle we can put a symbol named BINFMT_VERSION in the app; that symbol could be in .rodata and contain the string "1" or "$commit_hash". The difficulty is that the linker will drop the symbol if it's not used. We can force a use with something like (&BINFMT_VERSION as *const u8).read_volatile() for example but the question is where to put that load; it must be reachable from the app logic or it will be optimized away and won't appear in the final artifact.

But yeah would be good to have something like that.

@japaric japaric deleted the unstable branch August 7, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants