Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parentheses around format args #81

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Add missing parentheses around format args #81

merged 1 commit into from
Aug 7, 2020

Conversation

jonas-schievink
Copy link
Contributor

Fixes #79

japaric
japaric approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that's why core::write! and similar were also wrapping the args in parenthesis. Thanks!

@japaric japaric merged commit 5db4f10 into main Aug 7, 2020
@jonas-schievink jonas-schievink deleted the parens branch August 7, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

casting inside a logging macro call causes compile error
2 participants
@jonas-schievink @japaric