Support octal display hint #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,8 @@ fn main() -> ! { | |||
| defmt::info!("hex alt {=u8:#x}", x); | |||
| defmt::info!("HEX {=u8:X}", x); | |||
| defmt::info!("HEX alt {=u8:#X}", x); | |||
| defmt::info!("octal {=u8:o}", x); | |||
There was a problem hiding this comment.
Could we add the tests at the end, to minimise the diff on the expected output file?
There was a problem hiding this comment.
Oh, actually, that probably isn't going to help. Never mind.
jonathanpallant
approved these changes
Jul 15, 2024
Urhengulas
added
the
breaking change
Urhengulas
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Looks good to me.
Please not that this is a breaking change in defmt-parser, since we add a new enum variant to a public enum. I think this is fine though, since the parser is still marked unstable and as far as I know, no one is using the parser directly, everyone is using the decoder, or defmt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests and docs based on the binary display hint.