Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use native Node.js modules, support Node.js v20+ and modernize the code #180

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

3imed-jaberi
Copy link
Member

@3imed-jaberi 3imed-jaberi commented Aug 14, 2024

Changelog

  • Refactor the library to be with OOP class style
  • Support Node.js 20+
  • Bump all dependeices at the latest compatible versions with the current implementation
  • Replace methods dependency with native Node.js methods
  • Replace should and expect.js dependencies with native Node.js assert module
  • Migrate all test cases from done-callback style to async/await style
  • Fix [fix] @koa/router does not handle decoding URL with '+' character properly #179

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@3imed-jaberi 3imed-jaberi self-assigned this Aug 14, 2024
Copy link

socket-security bot commented Aug 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +94 10.7 MB eslintbot
npm/nyc@17.0.0 environment, filesystem, unsafe Transitive: eval, shell +144 14.6 MB bcoe
npm/supertest@7.0.0 network Transitive: environment, eval, filesystem +33 1.81 MB titanism

🚮 Removed packages: npm/eslint@8.39.0, npm/nyc@15.1.0, npm/supertest@6.3.4

View full report↗︎

@3imed-jaberi 3imed-jaberi changed the title Refactor the module to use native Node.js modules, support Node.js v20+ and modernize the code Refactor to use native Node.js modules, support Node.js v20+ and modernize the code Aug 15, 2024
@3imed-jaberi 3imed-jaberi marked this pull request as ready for review August 15, 2024 01:41
@titanism titanism merged commit f7ffb93 into master Aug 15, 2024
6 checks passed
@titanism titanism deleted the imed-upgrade-pre-v13 branch August 15, 2024 02:36
@titanism
Copy link
Contributor

@3imed-jaberi can you also submit a PR that takes care of this? f7ffb93#r145401932

then I can release to npm major version bump

@titanism
Copy link
Contributor

awesome work, btw 🙏 🎉

@titanism
Copy link
Contributor

also @3imed-jaberi is there any reason why node v18 would not be supported?

@3imed-jaberi
Copy link
Member Author

@titanism honestly no reason, if you want we can support it until the v18 end of life

@titanism
Copy link
Contributor

That would be great, can you PR?

@3imed-jaberi
Copy link
Member Author

@titanism PR: ---> #181

@titanism
Copy link
Contributor

Just waiting on tests to finish and then will merge/release.

Also – can you join our Matrix chat channel? We're "forwardemail" username in there 😄 We don't have Slack anymore.

https://matrix.to/#/#forwardemail:matrix.org

@3imed-jaberi
Copy link
Member Author

@titanism thanks for mentioning that because I was surprised with Slack last time 😅!

@titanism
Copy link
Contributor

v13.0.0 released to npm 🎉

https://github.com/koajs/router/releases/tag/v13.0.0

3imed-jaberi added a commit that referenced this pull request Sep 17, 2024
…rnize the code (#180)

* refactor: upgrade deps + refactor code to be with oop class style + support node.js 20+ ...etc

* fix: add fix for #179 issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] @koa/router does not handle decoding URL with '+' character properly
2 participants