Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider passing output views by const& #158

Closed
tpadioleau opened this issue Oct 8, 2024 · 1 comment · Fixed by #161
Closed

Consider passing output views by const& #158

tpadioleau opened this issue Oct 8, 2024 · 1 comment · Fixed by #161

Comments

@tpadioleau
Copy link
Collaborator

I don't think we want our API to handle allocations of output views ? I would suggest to pass output views by const& so that the user is guaranteed KokkosFFT will not overwrite it.
This was referenced Oct 8, 2024
Merged
Closed
@yasahi-hpc
Copy link
Collaborator

I think it should work. Not sure about hfft and ihfft

@tpadioleau tpadioleau mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass output views by const ref tpadioleau/kokkos-fft
2 participants
@tpadioleau @yasahi-hpc